From 60defe3864a5bb62858b9f6bc7745b1697abb118 Mon Sep 17 00:00:00 2001 From: Olli Etuaho Date: Tue, 24 Nov 2020 13:38:59 +0200 Subject: [PATCH] Remove manual render state setting Nested render calls now automatically restore the correct render state from the stack. getRenderState/setRenderState are not part of the public API so they can be safely removed from WebGLRenderer. --- src/renderers/WebGLRenderer.js | 12 ------------ src/renderers/webgl/WebGLCubeMaps.js | 2 -- 2 files changed, 14 deletions(-) diff --git a/src/renderers/WebGLRenderer.js b/src/renderers/WebGLRenderer.js index f144d2330299f6..b8424da18ae4de 100644 --- a/src/renderers/WebGLRenderer.js +++ b/src/renderers/WebGLRenderer.js @@ -1768,18 +1768,6 @@ function WebGLRenderer( parameters ) { }; - this.getRenderState = function () { - - return currentRenderState; - - }; - - this.setRenderState = function ( renderState ) { - - currentRenderState = renderState; - - }; - this.getRenderTarget = function () { return _currentRenderTarget; diff --git a/src/renderers/webgl/WebGLCubeMaps.js b/src/renderers/webgl/WebGLCubeMaps.js index 6679efb706aaaa..e23f85ba01cb56 100644 --- a/src/renderers/webgl/WebGLCubeMaps.js +++ b/src/renderers/webgl/WebGLCubeMaps.js @@ -42,7 +42,6 @@ function WebGLCubeMaps( renderer ) { const currentRenderList = renderer.getRenderList(); const currentRenderTarget = renderer.getRenderTarget(); - const currentRenderState = renderer.getRenderState(); const renderTarget = new WebGLCubeRenderTarget( image.height / 2 ); renderTarget.fromEquirectangularTexture( renderer, texture ); @@ -50,7 +49,6 @@ function WebGLCubeMaps( renderer ) { renderer.setRenderTarget( currentRenderTarget ); renderer.setRenderList( currentRenderList ); - renderer.setRenderState( currentRenderState ); texture.addEventListener( 'dispose', onTextureDispose );