Ignore pattern not working proprerly

[Njaah-0]

Environment

• OS Version: MacOS Big Sur 11.4
• Node.js Version: q2.22
• Fast-glob: 3.2.7

Actual behavior

Applying pattern that has ! doesn't seem to ignore correctly. When same, reversed pattern is used in ignore option, it works properly

Expected behavior

Steps to reproduce

1. See the image.

Code sample

const fg = require('fast-glob');

const entries = fg.sync(['./insertyourtestfolderhere/!(*.d).{ts,tsx}'], {
  dot: true,
  // ignore: ['./insertyourtestfolderhere/(*.d).{ts,tsx}'],
});

console.log(entries);

[leethree]

i'm having the same issue with pattern src/**/!(*.test).{ts,tsx}

[jrunning]

I'm seeing the same behavior with the pattern components/**/*!(.stories).js and every variation I've tried. Is there any update on this?

[jrunning]

Here's a super-simple repro:

$ ls
my-component.js
my-component.stories.js
MyComponent.js

$ node -e "let fg = require('fast-glob'); console.log(fg.sync('*!(.stories).js'))"
[ 'MyComponent.js', 'my-component.js', 'my-component.stories.js' ]

[mrmlnc]

About !(*.d).{ts,tsx} → 🐛

const re = micromatch.makeRe('!(*.d).{ts,tsx}')
/^(?:(?=.)(?:(?!(?:[^/]*?\.d).{ts,tsx})[^/]*?)\.(ts|tsx))$/

re.test('file.d.ts') → true

Looks like a bug in the micromatch package.

Just a few similar cases:

• Glob **/!(*-dbg).@(js) is wrongly translated into RegExp and thus DOES match -dbg.js files micromatch/picomatch#93

About *!(.stories).js → ✔

The glob package also match component.js and component.stories.js for *!(.stories).js. But works correctly for !(*.stories).js.

According to Bash, it looks like this is valid behavior.

$ ls *!(.stories).js
component.js  component.stories.js

$ ls !(*.stories).js
component.js

[timtim17]

I was encountering some quirkiness earlier, and I wasn't sure if it was similar to this issue.

aus@Austins-MBP src % tree -a
.
├── foo
│   ├── bar.txt
│   └── ignore.txt
├── index.js
└── test
    ├── baz
    │   ├── .not_this_either.txt
    │   └── also_no.txt
    └── no.txt

3 directories, 6 files

const fg = require('fast-glob');

const resultsA = fg.sync('**/*.txt', {
    ignore: ['**/test/**/*']
});
console.log(resultsA);

const resultsB = fg.sync('**/!(ignore)*.txt', {
    ignore: ['**/test/**/*']
});
console.log(resultsB);

const resultsC = fg.sync('**/!(ignore)*.txt', {
    ignore: ['**/test/**']
});
console.log(resultsC);

aus@Austins-MBP src % node index.js
[ 'foo/bar.txt', 'foo/ignore.txt' ]
[ 'foo/bar.txt', 'test/baz/.not_this_either.txt' ]
[ 'foo/bar.txt' ]

Results A: Works as expected. Gets all txt files, ignoring any in the test directory.
Results B: Does not work as expected. It does correctly give me all text files in the foo folder, except for the ignored ignore.txt, but it also gives me one of (but notably not all) files in the test directory.
Results C: Works as expected, after making a slight change to the ignore option.

I only encounter this when an ignore pattern is added to my pattern. If this is working as intended, or not related to this issue, please let me know. Thanks!

[mrmlnc]

Awaiting micromatch/picomatch#102.

[mrmlnc]

@timtim17, looks like a separate problem. Please fill another issue.

[mrmlnc]

Fixed by micromatch/picomatch#102 and released in 2.3.1. Since this is a transitive dependency on micromatch, it is enough to reinstall this package by npm i fast-glob.