Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation #417

Open
tzargar8 opened this issue Mar 18, 2024 · 8 comments
Open

Installation #417

tzargar8 opened this issue Mar 18, 2024 · 8 comments

Comments

@tzargar8
Copy link

tzargar8 commented Mar 18, 2024

This is going to look stupid, but still; your readme says: "The GitHub Releases page contains prebuilt toolchains that can be downloaded and installed by just unpacking them". Did you maybe forget something? That doesn't "install" anything, maybe I should have some environment variable pointing to one of those executables also or something? But there's tons of them.

@longnguyen2004
Copy link
Contributor

Probably just mean "ready to use after extracting". Users are expected to know how to setup environment variables and the like.

@Andarwinux
Copy link
Contributor

All you need to do is append llvm-mingw/bin to the top of $PATH, that's all.

@tzargar8
Copy link
Author

Seems that _MSC_VER isn't defined?

@Andarwinux
Copy link
Contributor

It's mingw toolchain, and _MSC_VER is a macro specific to msvc toolchain. If you need msvc build environment then you should consider https://github.com/mstorsjo/msvc-wine

@tzargar8
Copy link
Author

I see, I switched to MSVC and no problem. But it's a weird thing MSVC automatically outputs .lib .ilk etc. which was the only problem I had with this llvm-mingw, do you happen to know why?

@Andarwinux
Copy link
Contributor

This is one of the differences between MSVC and GNU. The .lib is MSVC style static or import library, while GNU style is .a. The format of these libraries is compatible, so the import library is also compatible, but the static library is not, because the ABI is different between the two.

@tzargar8
Copy link
Author

I see. So the _MSC_VER not being defined was the problem since it switched between __declspec(dllexport) and attribute((visibility("default"))), out of which the dllexport apparently has those files output automatically to conform to the stuff you said I guess.

It should work though if I added those files manually to the build output? Or bypassed the _MSC_VER in the defines.

@longnguyen2004
Copy link
Contributor

Seems like your code is currently dependent on MSVC. I'd advise you to refactor and use what's available on both compilers (example: use _WIN32 instead of _MSC_VER to check for Windows)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants