Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in python buildscript #426

Open
nullorigin opened this issue Apr 25, 2024 · 1 comment
Open

typo in python buildscript #426

nullorigin opened this issue Apr 25, 2024 · 1 comment

Comments

@nullorigin
Copy link

nullorigin commented Apr 25, 2024

Hi, you forgot to put a slash on the line above --fPIC in the configure section of build-python.sh. It is causing a linker error related to python and lldb.
Here is a block of code with the correction:

../configure --prefix="$PREFIX" --build=$BUILD --host=$HOST
CFLAGS="-I$PREFIX/include" CXXFLAGS="-I$PREFIX/include" LDFLAGS="-L$PREFIX/lib -Wl,-s"
PKG_CONFIG_LIBDIR="$PREFIX/lib/pkgconfig"
--with-build-python="$NATIVE_PYTHON"
--enable-shared
--with-system-ffi
--without-ensurepip
--without-c-locale-coercion
--fPIC

And here is that block of code currently:

../configure --prefix="$PREFIX" --build=$BUILD --host=$HOST
CFLAGS="-I$PREFIX/include" CXXFLAGS="-I$PREFIX/include" LDFLAGS="-L$PREFIX/lib -Wl,-s"
PKG_CONFIG_LIBDIR="$PREFIX/lib/pkgconfig"
--with-build-python="$NATIVE_PYTHON"
--enable-shared
--with-system-ffi
--without-ensurepip
--without-c-locale-coercion
--fPIC

Just thought I should let you know. And I think this project is very handy. So much easier to setup llvm rather than manually compiling it.

EDIT: Even still, if its not there, it needs to be, because of an error that is thrown when linking. The error says
something similar to "recompile with -fPIC enabled". It happen's when lldb is linking with python. I'll show you the exact error with context, just give me some time to build your project again without the ==fPIC option in the python build script.

@mstorsjo
Copy link
Owner

I'm not quite sure what you refer to here - the two blocks of code you quoted are identical, and our build-python.sh script doesn't contain any instance of --fPIC: https://github.com/mstorsjo/llvm-mingw/blob/master/build-python.sh#L149-L156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants