fix: clone Response before logging #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 37e73c8:
|
kettanaito
commented
Jul 19, 2023
| ok: response.status >= 200 && response.status < 300, | ||
| url: '', | ||
| type: 'default', | ||
| return new Response(response.body, { |
There was a problem hiding this comment.
It scares me a bit why the previous logic was contrived here. This function is only called in the fallback mode, which is browser-only if the Service Worker API is not available (old browsers, locally-served apps). Since we are in the browser, we can rely on Response, we always could.
wjkawecki
approved these changes
Jul 19, 2023
Released: v1.2.3 🎉This has been released in v1.2.3! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
IsomorphicResponse -> Responseconstruction for the fallback mode (in-browser only) now uses the standardResponseclass (every response can now be cloned).serializeResponsebefore reading its body.