-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use typescript@4.8 as the minimal supported version #2251
Conversation
@kettanaito here is another PR to resolve a potential conflict between the used version of |
This is incorrect. MSW still supports TS 4.7 and up. With your change, you are effectively removing that support. There's no discrepancy possible because what we install for development is irrelevant as long as it's in the supported TS version range. That's why each build runs an extensive type test suite on every supported version of TS to let us know if we break anything up or down the line. msw/.github/workflows/compat.yml Lines 55 to 57 in 8a9568a
Give this a look. I will likely close this.
|
@kettanaito My advice would be though to set the SemVer range between 4.8.X and 5.X.X, because in the current setup it would also automatically resolve to higher major versions. Which can possibly break the package for end users. |
Yep! Exactly my point, we have. There's been a dedicated effort for 5.x support, and we've adjusted the types so they work fine across 4.x and 5.x 👌 The automation I linked as the proof of that.
We discussed this previously as well (sorry, cannot find that discussion right now). TL;DR MSW supports all TS versions by default, if there's a bug, you report it. That's a better experience than throwing errors on install whenever you upgrade a TS to a version not listed in MSW's peer dependencies. There's no guarantee that the version will break. Would you like to bump the minimal peer dependency version for TS to 4.8.x with this change? That is indeed an issue we have right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the typescript peer dependency to correspond to the minimal supported version (4.8).
typescript
from 4.7.x to 5.5.x in peerDependencies
Released: v2.4.2 🎉This has been released in v2.4.2! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
To fix the discrepancy between the dev dependency and the version installed by end users