Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating make from 4.2.1-1 to 4.3-1 breaks mame build #6161

Closed
belegdol opened this issue Feb 1, 2020 · 4 comments
Closed

updating make from 4.2.1-1 to 4.3-1 breaks mame build #6161

belegdol opened this issue Feb 1, 2020 · 4 comments

Comments

@belegdol
Copy link

belegdol commented Feb 1, 2020

Hello,
I have originally reported this to mame team:
mamedev/mame#6248
After updating make to 4.3 mame build fails at ar stage:

$ LANG=C make VERBOSE=1 SUBTARGET=tiny TOOLS=1 OPTIMIZE=2 -j12
GCC 9.2.0 detected
make -R verbose=1 -C build/projects/windows/mametiny/gmake-mingw64-gcc config=release64 WINDRES=/mingw64/bin/windres precompile
make[1]: Entering directory '/c/Users/beleg/source/repos/belegdol/mame/build/projects/windows/mametiny/gmake-mingw64-gcc'
make[1]: Leaving directory '/c/Users/beleg/source/repos/belegdol/mame/build/projects/windows/mametiny/gmake-mingw64-gcc'
make -R verbose=1 -C build/projects/windows/mametiny/gmake-mingw64-gcc config=release64 WINDRES=/mingw64/bin/windres
make[1]: Entering directory '/c/Users/beleg/source/repos/belegdol/mame/build/projects/windows/mametiny/gmake-mingw64-gcc'
Archiving libemu.a...
rm -f "../../../../mingw-gcc/bin/x64/Release/libemu.a"
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ar.exe: ../../../../mingw-gcc/bin/x64/Release/libemu.a../../../../mingw-gcc/obj/x64/Release/src/emu/addrmap.o: No such file or directory
make[2]: *** [emu.make:932: ../../../../mingw-gcc/bin/x64/Release/libemu.a] Error 1
make[1]: *** [Makefile:88: emu] Error 2
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/c/Users/beleg/source/repos/belegdol/mame/build/projects/windows/mametiny/gmake-mingw64-gcc'
make: *** [makefile:1076: windows_x64] Error 2

It appears to me that there is a space missing between libemu.a and the path leading to addrmap.o. In order to reproduce it, one needs to install msys2, clone mame repository, run mingw64, cd into the checked out tree and run:

$ export MINGW64=/mingw64
$ make VERBOSE=1 SUBTARGET=tiny TOOLS=1 OPTIMIZE=2 -j12
@lazka
Copy link
Member

lazka commented Feb 2, 2020

The make release notes mention some backwards incompatible changes related to no longer adding spaces in some cases: https://lwn.net/Articles/810071/

Maybe you can check if this is the problem here.

@lazka
Copy link
Member

lazka commented Feb 10, 2020

Looks like this is fixed upstream now?

@belegdol
Copy link
Author

Yes it is, apologies for the delay.

@lazka
Copy link
Member

lazka commented Feb 11, 2020

ok, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants