Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aftertouch not mapped continuously #181

Open
kjyv opened this issue Jan 8, 2018 · 4 comments
Open

Aftertouch not mapped continuously #181

kjyv opened this issue Jan 8, 2018 · 4 comments

Comments

@kjyv
Copy link

kjyv commented Jan 8, 2018

When mapping aftertouch to a parameter, I see that it is changed at the same time the note on is sent (i.e. I play the note). While still holding the key down, the parameter is not changing anymore even though I can see that channel pressure events are sent continuously using a midi monitor.

@jfrey-xx
Copy link

jfrey-xx commented Jan 8, 2018

Hello,

I think I had a similar issue, could it be related to #170?

@mtytel
Copy link
Owner

mtytel commented Jan 8, 2018

I think channel pressure is different than aftertouch. I'll see if I can default to channel pressure if aftertouch isn't available.

@jfrey-xx
Copy link

jfrey-xx commented Jan 8, 2018

I think implemented that in my PR #170, @kjyv you can maybe test the code and see if the new behavior matches what you expect?

@kjyv
Copy link
Author

kjyv commented Jan 8, 2018

Ah this sounds likely. Both types of aftertouch should be handled then.
@jfrey-xx I've tried your PR and it works as intended, see my PR comment for a suggestion to fix a runtime error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants