[Drawer] breaks DOM scrolling when shown while hiding dialog

[rob2d]

If you have a scrolling page with a dockable LeftNav and docked={false}, and that LeftNav is the parent of a React component, it creates a giant div that breaks scrolling if you attempt to show it upon closing another modal dialog (using states as switches).

Currently using:
ReactJS : 0.14.7
Material-UI : HEAD@1d4c4a8
Google Chrome Version 47.0.2526.106

[mbrookes]

Thanks for the clear report! 👍

An example would be good too, so we can reproduce this.

Do you want to have a go at fixing it?

[rob2d]

I haven't had a chance to figure it out since unfortunately (well fortunately) I can still test the rest of my app for the time being (its a CMS) and I had a lot of other priorities/deadlines with my current sprint.

I did look around earlier this week to get these details and couldn't out my finger on what it changed in the DOM to cause this spefically... but I noticed it happened as soon as I created a LeftNav component that was self contained within its own React Component render (and this issue doesn't occur when docked=true, however for a modal this is not too great). Sorry for not being more elaborate, but if I can find some time to make a jist next week I will definitely do that.

[rob2d]

Well, this thing seems beyond me. Since it seems a pretty serious UI issue, can one of the project devs look into it? I can also confirm that this issue seems to be global (as in all browsers) as it also breaks my Firefox (v42.0)

[mbrookes]

Without an example to reproduce the issue with, there's really very little we can do to help, sorry.

[rob2d]

Sorry about the delayed response; I had a chance to look into it today found the issue more specifically! It basically happens if you have any dialog pop up, close it via a state flag during an action while simultaneously pulling out the LeftNav (also via setState). For now, I am using a workaround of setting few ms timeout before updating state on the callback, but it's still an issue. I will also test a few alternative fixes as workaround now that are not as hacky.

[oliviertassinari]

We have been porting the component on the v1-beta branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.
Still, we will accept PR fixes until v1-beta takes over the master branch.