Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Deprecated TablePagination SelectProps usage #41062

Closed
ghost opened this issue Feb 11, 2024 · 4 comments · Fixed by #41186
Closed

[docs] Deprecated TablePagination SelectProps usage #41062

ghost opened this issue Feb 11, 2024 · 4 comments · Fixed by #41186
Labels
component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature good first issue Great for first contributions. Enable to learn the contribution process. ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@ghost
Copy link

ghost commented Feb 11, 2024 •
edited by github-actions bot
Loading

Related page

https://mui.com/material-ui/react-table/#custom-pagination-actions

Kind of issue

Other

Issue description

The example code/CodeSandbox/StackBlitz use the now-deprecated SelectProps property, which should be converted to slotProps instead.

Context

Documentation examples should ideally not use deprecated methods.

Search keywords: Deprecated TablePagination SelectProps
@ghost ghost added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Feb 11, 2024
@oliviertassinari oliviertassinari added component: select This is the name of the generic UI component, not the React module! component: table This is the name of the generic UI component, not the React module! labels Feb 11, 2024
@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation good first issue Great for first contributions. Enable to learn the contribution process. enhancement This is not a bug, nor a new feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Feb 12, 2024
@ZeeshanTamboli ZeeshanTamboli removed the component: select This is the name of the generic UI component, not the React module! label Feb 12, 2024
@DiegoAndai DiegoAndai self-assigned this Feb 12, 2024
@DiegoAndai DiegoAndai added the ready to take Help wanted. Guidance available. There is a high chance the change will be accepted label Feb 12, 2024
@DiegoAndai DiegoAndai removed their assignment Feb 12, 2024
@DiegoAndai
Copy link
Member

Part of #40417

@DiegoAndai DiegoAndai mentioned this issue Feb 12, 2024
Open
@gitstart
Copy link
Contributor

@HaluanUskoa @DiegoAndai we would like to pick this up

@DiegoAndai
Copy link
Member

@gitstart thanks! go ahead 😊

@petsdom petsdom mentioned this issue Feb 17, 2024
Closed
1 task
@petsdom
Copy link

petsdom commented Feb 17, 2024

Hey @DiegoAndai i have made a pull request for this issue! #41146

@danilo-leal danilo-leal mentioned this issue Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature good first issue Great for first contributions. Enable to learn the contribution process. ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[material-ui][docs] Inform about deprecated TablePagination SelectProps usage gitstart/material-ui
6 participants
@gitstart @oliviertassinari @DiegoAndai @siriwatknp @ZeeshanTamboli @petsdom