Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align checkbox icons #4235

Closed
danibram opened this issue May 11, 2016 · 4 comments
Closed

Align checkbox icons #4235

danibram opened this issue May 11, 2016 · 4 comments
Labels
component: checkbox This is the name of the generic UI component, not the React module! v0.x

Comments

@danibram
Copy link

danibram commented May 11, 2016

Problem description

The problem is when the label have 2 lines the icon is not correctly centered.

This are the html of the checkbox

We solve with adding alignItems: 'center' to the parent of the icon + label, please add a fix or a possibility to put a value for the align items.

Versions

  • Material-UI: "0.15.0-alpha.2"
  • React: "0.14.8
  • Browser: Chrome Versión 50.0.2661.94
@tintin1343
Copy link
Contributor

I am very sure of this. I think this looks just fine, may be I am wrong. The spec clearly does not mention anything. I would like the other collaborators to respond to this.

@callemall/material-ui : Guys, would like you opinion about this. Thanks!

@oliviertassinari
Copy link
Member

@tintin1343 Well, if the spec doesn't mention anything, I would just keep it like it. That looks good, but my point of view is subjective.

@mbrookes
Copy link
Member

I mentioned to @tintin1343 that while the spec doesn't say anything specifically about checkbox alignment to multi-line text, and has no examples that I could find, the general rule does seem to be that icons are vertically centered relative to the text they accompany, so could apply here. There's no right or wrong though.

@mpontikes
Copy link

@tintin1343 You think this issue can be closed then?

@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@aahan96 aahan96 closed this as completed Aug 16, 2016
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: checkbox This is the name of the generic UI component, not the React module! v0.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: checkbox This is the name of the generic UI component, not the React module! v0.x
Projects
None yet
Development

No branches or pull requests

7 participants