Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Divider] Add aria-orientation #43275

Closed
aarongarciah opened this issue Aug 12, 2024 · 0 comments · Fixed by #43241
Closed

[material-ui][Divider] Add aria-orientation #43275

aarongarciah opened this issue Aug 12, 2024 · 0 comments · Fixed by #43241
Assignees
@aarongarciah
Labels
accessibility a11y component: divider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Milestone
Material UI: v6

Comments

@aarongarciah
Copy link
Member

aarongarciah commented Aug 12, 2024 •
edited
Loading

The Divider renders an <hr> when using vertical orientation. To adhere to the ARIA spec, we should update the implementation to render <div role="separator" aria-orientation="vertical"> when in vertical mode.

Benchmarks
@aarongarciah aarongarciah self-assigned this Aug 12, 2024
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 12, 2024
@aarongarciah aarongarciah mentioned this issue Aug 12, 2024
Merged
@aarongarciah aarongarciah added package: material-ui Specific to @mui/material component: divider This is the name of the generic UI component, not the React module! accessibility a11y and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 12, 2024
@aarongarciah aarongarciah added this to the Material UI: v6 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarongarciah aarongarciah

Labels
accessibility a11y component: divider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
Material UI
Status: Done
Milestone
Material UI: v6
Development

Successfully merging a pull request may close this issue.

[material-ui][Divider] Add aria-orientation mui/material-ui
1 participant
@aarongarciah