Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab panel disappears when selecting checkbox #4403

Closed
nikhilshagri opened this issue Jun 1, 2016 · 7 comments
Closed

Tab panel disappears when selecting checkbox #4403

nikhilshagri opened this issue Jun 1, 2016 · 7 comments
Labels
component: checkbox This is the name of the generic UI component, not the React module! component: tabs This is the name of the generic UI component, not the React module!

Comments

@nikhilshagri
Copy link

I have a tabs component with multiple tabs inside it, and I have a checkbox component inside one of the tabs' content panels. Whenever I select/deselect the checkbox, all the content of that tab panel just disappears.
The same happens when I use a plain HTML checkbox, and also when I use the material-ui 'Toggle' component'. I haven't tested for other components yet.

@puranjayjain
Copy link
Contributor

@cynicaldevil do you have a demo or can I look into your source code?

@nikhilshagri
Copy link
Author

@puranjayjain Where can I post a demo?

@puranjayjain
Copy link
Contributor

@cynicaldevil in a new github repo.

@brunor
Copy link

brunor commented Jun 1, 2016

I've seen this happen as well. Calling event.stopPropagation() from inside the checkbox onCheck handler fixed the issue for me.

@nikhilshagri
Copy link
Author

@brunor It works!!
Thanks a lot, I had been struggling with this issue for quite a while now. Any idea why does this happen, though?

@izziaraffaele
Copy link
Contributor

I have the same issue with TextField component. If it's within the Tab, the onChange event on the TextField component will propagate till the Tabs component

@ozluy
Copy link

ozluy commented Jul 25, 2016

I guess we must call event.stopPropagation() in any event inside the Tabs' content.

@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@aahan96 aahan96 closed this as completed Aug 16, 2016
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: checkbox This is the name of the generic UI component, not the React module! component: tabs This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: checkbox This is the name of the generic UI component, not the React module! component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

8 participants