Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] add a fullWidth property #4823

Closed
Mangatt opened this issue Jul 25, 2016 · 2 comments
Closed

[Button] add a fullWidth property #4823

Mangatt opened this issue Jul 25, 2016 · 2 comments
Labels
component: button This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request

Comments

@Mangatt
Copy link
Contributor

Mangatt commented Jul 25, 2016

Hi guys,
FlatButton should be IMO fully interexchangeable with RaisedButton. Mainly fullWidth attribute is missing in my case.

What do you think?
@mpontikes mpontikes mentioned this issue Aug 5, 2016
Closed
13 tasks
@oliviertassinari
Copy link
Member

FlatButton should be IMO fully interchangeable with RaisedButton

I agree, we have merged the two components on the next branch to address that concern.
That's much better. We don't provide a fullWidth property. I think that it would be good to add it back.

@oliviertassinari oliviertassinari changed the title FlatButton fullWidth [Button] add a fullWidth property Feb 12, 2017
@oliviertassinari oliviertassinari added new feature New feature or request next component: button This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. labels Feb 12, 2017
@Shahrukh-Zindani
Copy link

@oliviertassinari fullWidth property has been added to FlatButton. This issue is ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: button This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mangatt @oliviertassinari @Shahrukh-Zindani