Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Overlay] Expose this internal component #4827

Closed
stunaz opened this issue Jul 25, 2016 · 4 comments
Closed

[Overlay] Expose this internal component #4827

stunaz opened this issue Jul 25, 2016 · 4 comments
Labels
new feature New feature or request

Comments

@stunaz
Copy link
Contributor

stunaz commented Jul 25, 2016

Hi,
I would be nice to have a boolean property to show/hide an overlay with the popover.

@mpontikes mpontikes mentioned this issue Aug 5, 2016
13 tasks
@oliviertassinari oliviertassinari added the component: Popover The React component. label Dec 18, 2016
@oliviertassinari oliviertassinari changed the title [Popover ]: Add overlay option to popover [Popover] Add overlay option to popover Dec 18, 2016
@dano-giftbit
Copy link

dano-giftbit commented Mar 29, 2017

We're looking at using the Overlay component with a custom Search component overlaid on it

To accomplish we're importing material-ui/internal/Overlay which works well but feels fragile with the "internal" nesting of the Overlay.

Given the various use cases, it might make sense to make Overlay a public component?

@oliviertassinari oliviertassinari added new feature New feature or request v1 labels Aug 26, 2017
@oliviertassinari
Copy link
Member

We do have an overlay component. I don't think that we should be backing it into the Popover. Still we could potentially move it out of the internal folder and document it.

@oliviertassinari oliviertassinari changed the title [Popover] Add overlay option to popover [Overlay] Expose this internal component Aug 29, 2017
@oliviertassinari oliviertassinari removed the component: Popover The React component. label Aug 29, 2017
@the-noob
Copy link
Contributor

the-noob commented Nov 7, 2017

As far as I can see there is a backdrop with the Popover with alpha 1, it would be good to be able to control that as, in some cases, makes sense to let the user know any other interaction is disabled.

i.e. I have a colour palette with swatches that show edit/delete actions on hover and, when clicking edit, a Popover with a colour picker shows right beneath. At this point, as there is no visual clue that the Popover is a blocking action, users reported that hovering over other swatches doesn't work.

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 7, 2017

The Popover inherits the properties of the Modal component. You can already provide a BackdropInvisible, BackdropClassName and BackdropComponent property. I will work on exposing the Modal component to the public API so the feature is better documented.

The issue can be closed. Here is a demo: https://codesandbox.io/s/322l1n9ym6.
capture d ecran 2017-11-07 a 21 06 28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants