Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip unavailable on v1 beta ? #7856

Closed
be-next-hotdog opened this issue Aug 21, 2017 · 3 comments
Closed

Tooltip unavailable on v1 beta ? #7856

be-next-hotdog opened this issue Aug 21, 2017 · 3 comments
Labels
component: tooltip This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists

Comments

@be-next-hotdog
Copy link

Hello,
As I considered, tooltip was also removed ? We'll create a new independent Tooltip component instead ? :)

@oliviertassinari
Copy link
Member

We never had a true Tooltip component. I'm closing for #2230.

@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Aug 21, 2017
@be-next-hotdog
Copy link
Author

So we r about to follow the way as before by adding props on IconButton or ?

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 21, 2017

No, I think that we should have a first class component for the tooltip. It's definitely something that we miss. A component that we could be composed with a IconButton. Maybe something as below, but I can't tell for sure what's better. I haven't done any benchmark on what's done by others yet.

<Tooltip label="Github">
  <IconButton {...props} />
</Tooltip>

@oliviertassinari oliviertassinari added the component: tooltip This is the name of the generic UI component, not the React module! label Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tooltip This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants