Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port QUIC support #70

Merged
merged 5 commits into from
Jan 13, 2021
Merged

Port QUIC support #70

merged 5 commits into from
Jan 13, 2021

Conversation

fishmonger45
Copy link
Contributor

@vasco-santos
Copy link
Member

Thanks for the PR @wqsz7xn

A QUIC address should also be a reliable multiaddr address. This way, the following type of address should be valid and tested /ip4/1.2.3.4/udp/1234/quic/p2p/QmUjNmr8TgJCn1Ao7DvMy4cjoZU15b9bwSCBLE3vwXiwgj

@fishmonger45
Copy link
Contributor Author

@vasco-santos
Thanks for the review. I have added the test that you wanted.

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR

@vasco-santos vasco-santos merged commit ac7d10c into multiformats:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants