fix: Rename webrtc-w3c to webrtc and webrtc to webrtc-direct #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following on from #150 and an replacement for #151 Renames: - `/webrtc-w3c` -> `/webrtc` - AKA browser to browser - `/webrtc` -> `/webrtc-direct` - AKA browser to server Discussion: - This option was mentioned in #150 and seemed to have a reasonable amount of support but seemed to get lost amongst the other options - The differences in the protocols is mentioned in the table comments
achingbrain
added a commit
that referenced
this pull request
Mar 14, 2023
Following on from #150 and an replacement for #151 Renames: - `/webrtc-w3c` -> `/webrtc` - AKA browser to browser - `/webrtc` -> `/webrtc+sdp-munging` - AKA browser to server Discussion: - This option comes from comments on #151 - It got a lukewarm reception on the triage call so it's presented as an option along with #152 - Adding `+sdp-munging` makes it more explicit about the differences, though admittedly there are other differences that aren't encapsulated in the name - People were uncertain about universal understanding of the term "SDP munging"
This was referenced Mar 14, 2023
marten-seemann
approved these changes
Mar 14, 2023
MarcoPolo
approved these changes
Mar 15, 2023
achingbrain
added a commit
to multiformats/js-multiaddr
that referenced
this pull request
Mar 17, 2023
We have decided to rename `webrtc` to `webrtc-direct` and `webrtc-w3c` to `webrtc` as these better reflect the protocols being used. For further discussion please see: multiformats/multiaddr#150 This change landed in multiformats/multiaddr#152 BREAKING CHANGE: webrtc has been renamed webrtc-direct and webrtc-w3c has been renamed webrtc --------- Co-authored-by: Alex Potsides <alex@achingbrain.net>
2 tasks
achingbrain
pushed a commit
to multiformats/js-mafmt
that referenced
this pull request
Mar 20, 2023
Rename webrtc protocol from webrtc to webrtc-direct based on multiformats/multiaddr#152 . BREAKING CHANGE: the existing WebRTCDirect multicodec name has been deprecated and renamed P2PWebRTCDirect. The new WebRTCDirect codec has been added but is not the same, please check your code before upgrading! Integer codes are unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following on from #150 and a replacement for #151
Renames:
/webrtc-w3c->/webrtc- AKA browser to browser/webrtc->/webrtc-direct- AKA browser to serverDiscussion:
Before Merge