Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multicodec for libp2p key #130

Closed
lidel opened this issue May 13, 2019 · 0 comments · Fixed by #131
Closed

Add multicodec for libp2p key #130

lidel opened this issue May 13, 2019 · 0 comments · Fixed by #131

Comments

@lidel
Copy link
Member

lidel commented May 13, 2019 •
edited
Loading

We need a new multicodec to unlock PeerID representation in CIDv1 for subdomains.

Should I just PR a proposal with one? Which range should it be in?

Context
@Stebalien Stebalien mentioned this issue May 13, 2019
Merged
lidel added a commit to multiformats/js-multicodec that referenced this issue May 27, 2019
@lidel
feat: add libp2p-key
921799f 
This adds multicoded added in
multiformats/multicodec#130

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel added a commit to multiformats/js-multicodec that referenced this issue May 27, 2019
@lidel
feat: add libp2p-key
db71d5c 
This updates the lookup table to match
multiformats/multicodec/master/table.csv
and adds libp2p-key multicodec added in
multiformats/multicodec#130

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel mentioned this issue May 27, 2019
Merged
lidel added a commit to lidel/go-cid that referenced this issue May 27, 2019
@lidel
Add libp2p-key multicodec
6ee5538 
Context: multiformats/multicodec#130

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel mentioned this issue May 27, 2019
Merged
lidel added a commit to lidel/go-cid that referenced this issue May 27, 2019
@lidel
Add libp2p-key multicodec
3f17777 
Context: multiformats/multicodec#130

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
This was referenced Aug 19, 2019
Merged
Merged
@lidel lidel mentioned this issue Oct 28, 2019
Merged
@lidel lidel mentioned this issue Feb 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multicodec: add IPLD codec for libp2p public keys multiformats/multicodec
2 participants
@lidel and others