Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minclientversion checker for MTA 1.6 and on. #521

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

YelehaUwU
Copy link
Contributor

No description provided.

@Fernando-A-Rocha
Copy link
Contributor

I think mtasa.com should be changed to multitheftauto.com in the URLs

fetchRemote( "https://nightly.mtasa.com/ver/", onGotVersInfo )

fetchRemote( "http://nightly.mtasa.com/ver/acpanel/", onGotAcPanelVersInfo )

Also, I was unaware there was an endpoint that returns acpanel version. Logically, after updating the acpanel resource, the version in meta.xml should be bumped and also updated on that webpage.

Additionally, the outputChatBox("New version of Anti-Cheat panel is available!") should be switched to an outputServerLog imo.

@Fernando-A-Rocha
Copy link
Contributor

Fernando-A-Rocha commented Jul 18, 2024

I found a bug related to acpanel:

The URL displayed in https://nightly.mtasa.com/ver/acpanel/ leads to https://nightly.mtasa.com/index.php?p=resources&s=details&id=6242 which seems like it should have been on community.multitheftauto.com to land on the acpanel resource page... I'm not sure what this feature was ever for, and if it should remain.

image

@Dutchman101
Copy link
Member

I will add the other requests with some tweaks in a follow up commit; you didn't enable maintainer changes

@Dutchman101 Dutchman101 merged commit 86375c4 into multitheftauto:master Jul 19, 2024
@YelehaUwU YelehaUwU deleted the patch-2 branch July 19, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants