Skip to content

Commit

Permalink
Merge pull request #30 from thet/fix-install-option
Browse files Browse the repository at this point in the history
 Fix usage of "--install-option='pre'" and use "--pre" option in requirements files instead.
  • Loading branch information
rnixx committed Apr 22, 2023
2 parents bdd3f44 + 5c80172 commit 66e8e92
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

### 3.0.0b3 (unreleased)

- Fix usage of "--install-option='pre'" and use "--pre" option in requirements files instead.
The install options is deprecated in pip 23 which Plone switched to recently.
More info:
https://github.com/pypa/pip/issues/11358
https://discuss.python.org/t/passing-command-line-arguments-to-pip-install-after-install-options-deprecation/22981/6
[thet, fredvd]

- Fix reading sections from config parser without defaults if section contains setting which also exists as default.
[rnix]

Expand Down
2 changes: 1 addition & 1 deletion src/mxdev/processing.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def write_dev_sources(fio, packages: typing.Dict[str, typing.Dict[str, typing.An
continue
extras = f"[{package['extras']}]" if package["extras"] else ""
subdir = f"/{package['subdirectory']}" if package["subdirectory"] else ""
install_options = ' --install-option="--pre"'
install_options = ' --pre'
editable = (
f"""-e ./{package['target']}/{name}{subdir}{extras}{install_options}\n"""
)
Expand Down

0 comments on commit 66e8e92

Please sign in to comment.