-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrix docker (container) builds fail #156
Comments
@splitice it worked for me here: https://github.com/OctoKode/test1/runs/3767512089?check_suite_focus=true
|
Try with |
https://github.com/OctoKode/test1/runs/3767922670?check_suite_focus=true
Whatever you're running into is on the linux agent not the self-hosted
|
Container feature does work with the configuration I provided without the matrix. In either self hosted or github runner mode. It's only in self-hosed mode with this docker runner that matrix + container fails (I have no data on matrix + container without dind). This is the error you are chasing (taken from our failing action). |
Anyway container works in dind (with all apropriate docker in docker permissions). Configuration:
Adding matrix to the configuration does not. Offtopic FYI DIND nesting also works (Yocto does docker in docker within the job we fire off from Github Actions - in docker). But that's not using GHA containers. |
Using
fails as expected Adding |
I've run into this issue as well, and the problem seems to be that the first step it does when it spins up the services is to prune existing data with the same label. Each node in the matrix spins up with the same label, and the first one will prune and create a network, then the second one spins up and prunes again (with the SAME LABEL) and now the network doesn't exist anymore, and they fail. There must be a way to set a unique label per matrix node to isolate the services and prevent them from pruning eachother when they start up Update: This is a really stupid hack, but this is how I worked around it:
I found that the Github runner uses the sha256sum of the string of its root directory (https://github.com/actions/runner/blob/42fe704132b7fc343e59ff15a8dbaace19e38e62/src/Runner.Worker/Container/DockerCommandManager.cs#L49) to create the docker label. This string is the same for every container where that path is the same, which means the label is the same for all containers and they will prune each other when they start up as matrix nodes. In my
This is what my init script looks like:
Now the runner will start from a directory that looks like Probably not the best way to deal with this, but seems to work |
@myoung34 I suspect this is a Github Actions bug. Are you able to confirm (and I'll direct a issue to them accordingly).
Fails to start:
The strategy of matrix appears to be the issue but I can't see why.
Feedback apreciated.
The text was updated successfully, but these errors were encountered: