Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even if I ship an order without MyParcel the url of the shipment refers to https://myparcel.me #699

Open
gerben86 opened this issue Jun 28, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@gerben86
Copy link
Contributor

gerben86 commented Jun 28, 2022

Plugin version

4.5.0 and 4.9.0

Magento version

2.4.4

PHP version

7.4.30

What went wrong?

When an order should be shipped via MyParcel but I decide to use another shipping company I past the track-and-trace-url of that company in the field 'number' in the Magento Backend.
I also deselect the 'Create MyParcel consignment'. Check the printscreen below:
image

However, in the shipmentmail send to the customer the url looks like this: https://myparcel.me/track-trace/https://www.dhlparcel.nl/nl/particulier/ontvangen/volg-uw-zending?tt=J123123123&pc=1234AB/1234AB/NL
So it's redirected to https://myparcel.me, which results in a 404.

Why are you modifying the field 'Number' if the shipment isn't actually done via MyParcel?
This has customer impact, because I get complaints that the url isn't usable...

The url is generated in this file 'sdk/src/Helper/TrackTraceUrl.php'. There should be a check that it's actually shipped via MyParcel and only then the url should be created in this way, otherwise leave the 'shipment number' untouched.

Is there anyone who can provide me with a temporarily workaround, so that both the orders via MyParcel (90% of the orders) and the orders via another shippingcompany are processed fine?

Thanks!

Edit:
I added this as a temporarily workaround (just check if the value contains DHL, then don't modify it):
image

Reproduction steps

See above

Relevant log output

No response

Additional context

No response

@gerben86 gerben86 added the bug Something isn't working label Jun 28, 2022
@RichardPerdaan
Copy link
Member

Fixed in v4.6.0

@gerben86
Copy link
Contributor Author

I'm using now version 4.9.0 and this issue is back again...
So please reopen this issue

@gerben86
Copy link
Contributor Author

More then 1 year after creating the initial bug and half a year after reopening the ticket this is still existing...

While the fix is quite easy, as mentioned in the first comment.

@gerben86
Copy link
Contributor Author

gerben86 commented Feb 3, 2024

Issue still in v4.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

4 participants