fix: Fixed styleManager create element in ssr bug

Close #16
myxvisual · Aug 9, 2017 · 44cc7ca · 44cc7ca
1 parent 3bccabd
commit 44cc7ca
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/styles/StyleManager.ts b/src/styles/StyleManager.ts
@@ -1,4 +1,5 @@
 import * as createHash from "murmurhash-js/murmurhash3_gc";
+import IS_NODE_ENV from "../common/nodeJS/IS_NODE_ENV";
 import isUnitlessNumber from "../common/react/isUnitlessNumber";
 
 export const replace2Dashes = (key: string) => key.replace(/[A-Z]/g, $1 => `-${$1.toLowerCase()}`);
@@ -62,8 +63,9 @@ export class StyleManager {
   }
 
   setupStyleElement = () => {
-    const name = `data-uwp-jss-${this.themeId}`;
+    if (IS_NODE_ENV) return;
     if (!this.styleElement) {
+      const name = `data-uwp-jss-${this.themeId}`;
       this.styleElement = document.createElement("style");
       this.styleElement.setAttribute(name, "");
       document.head.appendChild(this.styleElement);

diff --git a/src/styles/getTheme.ts b/src/styles/getTheme.ts
@@ -65,7 +65,7 @@ export default function getTheme(themeConfig?: ThemeConfig): ReactUWP.ThemeType
     },
     useInlineStyle: Boolean(useInlineStyle),
 
-    styleManager: {},
+    styleManager: void 0,
 
     useFluentDesign,
     desktopBackground: void 0,
@@ -129,6 +129,7 @@ export default function getTheme(themeConfig?: ThemeConfig): ReactUWP.ThemeType
     isDarkTheme: isDark,
     prefixStyle: prefixAll(userAgent),
     prepareStyle(config, callback) {
+      if (!this.styleManager) return;
       const { extendsClassName, ...managerConfig } = config;
       if (this.useInlineStyle) {
         managerConfig.className += extendsClassName ? ` ${extendsClassName}` : "";
@@ -140,6 +141,7 @@ export default function getTheme(themeConfig?: ThemeConfig): ReactUWP.ThemeType
       }
     },
     prepareStyles(config, callback) {
+      if (!this.styleManager) return;
       if (this.useInlineStyle) {
         const { styles } = config;
         const result: any = {};