feat(API): Remove RatingControl iconNode props

myxvisual · Jun 20, 2017 · b76472d · b76472d
1 parent cf36477
commit b76472d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 16 deletions.
diff --git a/src/RatingControl/index.doc.json b/src/RatingControl/index.doc.json
@@ -48,12 +48,6 @@
           "isRequired": false,
           "type": "string"
         },
-        {
-          "name": "iconNode",
-          "documentation": "Control show custom `React.ReactNode`.",
-          "isRequired": false,
-          "type": "ReactNode"
-        },
         {
           "name": "iconStyle",
           "documentation": "Control custom `Icon Style`.",
@@ -181,7 +175,7 @@
         },
         {
           "name": "renderRatings",
-          "initializerText": " (notRated = true) => {\n    const { maxRating, iconNode, icon, iconStyle, iconRatedStyle, isReadOnly, iconPadding } = this.props;\n    const { currRating } = this.state;\n    const { theme } = this.context;\n    const ratio = currRating / maxRating;\n    const fontSize = iconStyle ? (+Number(iconStyle.fontSize) || 24) : 24;\n    const width = fontSize * maxRating + iconPadding * (maxRating - 1);\n    const offset = Math.floor(currRating) * (fontSize + iconPadding) + (currRating % 1) * fontSize;\n    const lastIndex = maxRating - 1;\n\n    const normalRatings = (\n      <div\n        style={{\n          ...this.styles.ratingsGroup,\n          ...(notRated ? void 0 : {\n            clipPath: `polygon(0% 0%, ${offset}px 0%, ${offset}px 100%, 0% 100%)`,\n            color: theme.accent,\n            position: \"absolute\",\n            top: 0,\n            left: 0\n          } as React.CSSProperties)\n        }}\n      >\n        {Array(maxRating).fill(0).map((zero, index) => (\n          iconNode || (\n            <Icon\n            key={`${index}`}\n            style={{\n              fontSize: 24,\n              paddingRight: index === lastIndex ? 0 : iconPadding,\n              ...iconStyle,\n              ...(notRated ? void 0 : iconRatedStyle)\n            }}\n            onClick={isReadOnly ? void 0 : e => {\n              this.handleRationClick(e, index);\n            }}\n          >\n            {icon}\n          </Icon>\n          )\n        ))}\n      </div>\n    );\n    return normalRatings;\n  }",
+          "initializerText": " (notRated = true) => {\n    const { maxRating,  icon, iconStyle, iconRatedStyle, isReadOnly, iconPadding } = this.props;\n    const { currRating } = this.state;\n    const { theme } = this.context;\n    const ratio = currRating / maxRating;\n    const fontSize = iconStyle ? (+Number(iconStyle.fontSize) || 24) : 24;\n    const width = fontSize * maxRating + iconPadding * (maxRating - 1);\n    const offset = Math.floor(currRating) * (fontSize + iconPadding) + (currRating % 1) * fontSize;\n    const lastIndex = maxRating - 1;\n\n    const normalRatings = (\n      <div\n        style={{\n          ...this.styles.ratingsGroup,\n          ...(notRated ? void 0 : {\n            clipPath: `polygon(0% 0%, ${offset}px 0%, ${offset}px 100%, 0% 100%)`,\n            color: theme.accent,\n            position: \"absolute\",\n            top: 0,\n            left: 0\n          } as React.CSSProperties)\n        }}\n      >\n        {Array(maxRating).fill(0).map((zero, index) => (\n          <Icon\n            key={`${index}`}\n            style={{\n              fontSize: 24,\n              paddingRight: index === lastIndex ? 0 : iconPadding,\n              ...iconStyle,\n              ...(notRated ? void 0 : iconRatedStyle)\n            }}\n            onClick={isReadOnly ? void 0 : e => {\n              this.handleRationClick(e, index);\n            }}\n          >\n            {icon}\n          </Icon>\n        ))}\n      </div>\n    );\n    return normalRatings;\n  }",
           "documentation": "",
           "type": "(notRated?: boolean) => Element"
         },

diff --git a/src/RatingControl/index.tsx b/src/RatingControl/index.tsx
@@ -16,10 +16,6 @@ export interface DataProps {
    * Control show custom `Icon`.
    */
   icon?: string;
-  /**
-   * Control show custom `React.ReactNode`.
-   */
-  iconNode?: React.ReactNode;
   /**
    * Control custom `Icon Style`.
    */
@@ -91,7 +87,7 @@ export class RatingControl extends React.Component<RatingControlProps, RatingCon
   }
 
   renderRatings = (notRated = true) => {
-    const { maxRating, iconNode, icon, iconStyle, iconRatedStyle, isReadOnly, iconPadding } = this.props;
+    const { maxRating,  icon, iconStyle, iconRatedStyle, isReadOnly, iconPadding } = this.props;
     const { currRating } = this.state;
     const { theme } = this.context;
     const ratio = currRating / maxRating;
@@ -114,8 +110,7 @@ export class RatingControl extends React.Component<RatingControlProps, RatingCon
         }}
       >
         {Array(maxRating).fill(0).map((zero, index) => (
-          iconNode || (
-            <Icon
+          <Icon
             key={`${index}`}
             style={{
               fontSize: 24,
@@ -129,7 +124,6 @@ export class RatingControl extends React.Component<RatingControlProps, RatingCon
           >
             {icon}
           </Icon>
-          )
         ))}
       </div>
     );
@@ -141,7 +135,6 @@ export class RatingControl extends React.Component<RatingControlProps, RatingCon
       defaultRating,
       maxRating,
       icon,
-      iconNode,
       iconStyle,
       iconRatedStyle,
       onChangeRating,