From 78d90156e9566e45505c6b537719103e2f0b6f30 Mon Sep 17 00:00:00 2001 From: n0099 Date: Thu, 13 Jun 2024 15:49:51 +0000 Subject: [PATCH] * fix `league/flysystem-local@3.28.0` requires `ext-fileinfo` but it's not enabled by default on windows @ be/action.yml * run `corepack enable` after `actions/setup-node` since nodejs is not installed on windows runner by default * upgrade node version from `lts` to `latest` @ fe/action.yml @ .github/actions --- .github/actions/be/action.yml | 2 ++ .github/actions/fe/action.yml | 9 +++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/actions/be/action.yml b/.github/actions/be/action.yml index f2a8577c..3c2d94b1 100644 --- a/.github/actions/be/action.yml +++ b/.github/actions/be/action.yml @@ -14,6 +14,8 @@ runs: # https://github.com/shivammathur/setup-php/blob/6d7209f44a25a59e904b1ee9f3b0c33ab2cd888d/README.md#jit-configuration coverage: none ini-values: opcache.enable_cli=1 + # https://github.com/shivammathur/setup-php/wiki/Php-extensions-loaded-on-windows-2022/aee619eb6d77e86b17a76d458316b41e58a3b677 + extension: fileinfo # league/flysystem-local@3.28.0 requires ext-fileinfo but it's not enabled by default on windows env: # https://github.com/shivammathur/setup-php/blob/6d7209f44a25a59e904b1ee9f3b0c33ab2cd888d/README.md#force-update-setup update: 'true' # https://github.com/shivammathur/setup-php/blob/6d7209f44a25a59e904b1ee9f3b0c33ab2cd888d/README.md#problem-matchers diff --git a/.github/actions/fe/action.yml b/.github/actions/fe/action.yml index f81238c8..69c4fe0f 100644 --- a/.github/actions/fe/action.yml +++ b/.github/actions/fe/action.yml @@ -7,18 +7,19 @@ runs: with: submodules: true - # https://github.com/actions/setup-node/issues/1027 - - run: corepack enable - shell: bash - uses: actions/setup-node@v4 with: # https://github.com/actions/setup-node/tree/v4 - node-version: lts/* + node-version: latest # cache: yarn # # https://github.com/actions/setup-node/issues/624#issuecomment-1328681525 # cache-dependency-path: ${{ github.workspace }}/fe/yarn.lock # in favor of https://github.com/actions/cache/blob/a2ed59d39b352305bdd2f628719a53b2cc4f9613/examples.md#node---yarn-2 # to allow saving cache even jobs failed + # https://github.com/actions/setup-node/issues/1027 + - run: corepack enable + shell: bash + - id: get-yarn-cache-dir run: echo "path=$(yarn config get cacheFolder)" >> $GITHUB_OUTPUT working-directory: fe