Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TA-Lib install broken in CI #1716

Open
cjdsellers opened this issue Jun 17, 2024 · 2 comments
Open

TA-Lib install broken in CI #1716

cjdsellers opened this issue Jun 17, 2024 · 2 comments
Assignees

Comments

@cjdsellers
Copy link
Member

Looks like something changed with ta-lib and the Python installation is currently broken:
TA-Lib/ta-lib-python#655

It appears two test modules are currently commented out:
https://github.com/nautechsystems/nautilus_trader/blob/develop/tests/unit_tests/indicators/test_talib_func_wrapper.py
https://github.com/nautechsystems/nautilus_trader/blob/develop/tests/unit_tests/indicators/test_talib_indicator_manager.py

Once ta-lib resolve this we can resume the installation step and tests in CI.

@cjdsellers
Copy link
Member Author

Hey @rsmb7z

Do we know if the TA-Lib installation issues have been resolved on their end?

@rsmb7z
Copy link
Collaborator

rsmb7z commented Aug 18, 2024

Hi @cjdsellers,
I'll work on it this week. I'll likely remove the TA-Lib dependency from the tests and use mocks instead, as we're focusing on testing the manager class, not the TA-Lib itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants