Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disposing the sink fails in the browser with PlatformNotSupportedException #16

Open
nblumhardt opened this issue May 25, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nblumhardt
Copy link
Owner

E.g. when calling Log.CloseAndFlush():

at System.Threading.Tasks.Task.Wait()
at Serilog.Sinks.PeriodicBatching.PeriodicBatchingSink.ResetSyncContextAndWait(Func`1 taskFactory)
at Serilog.Sinks.PeriodicBatching.PeriodicBatchingSink.CloseAndFlush()
at Serilog.Sinks.PeriodicBatching.PeriodicBatchingSink.Dispose(Boolean disposing)
at Serilog.Sinks.BrowserHttp.BrowserHttpSink.Dispose(Boolean disposing)
at Serilog.Sinks.PeriodicBatching.PeriodicBatchingSink.Dispose()

It's likely this will require specific support in PeriodicBatchingSink, but in the short term it may be better to grab the code from there, embed it in this library, and tweak until we're happy.

@nblumhardt nblumhardt added bug Something isn't working good first issue Good for newcomers labels May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant