From 6a0e3240be3b69fd549a74b30cf37a178f56df87 Mon Sep 17 00:00:00 2001 From: Nicolas Coden Date: Fri, 3 Aug 2018 00:34:27 +0200 Subject: [PATCH] fix: fix Dropdown Menu top level item properties #11412 Changes: - Only apply top-level styles to top-level items. This increase specificity but this markup structure is alreaddy assumed elsewhere in the component. - Remove the default `$white` background on top-level items: it was never applied before #11377 and could now cause visual changes. Closes https://github.com/zurb/foundation-sites/issues/11412 --- scss/components/_dropdown-menu.scss | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/scss/components/_dropdown-menu.scss b/scss/components/_dropdown-menu.scss index 6972df4b99..d2d348033b 100644 --- a/scss/components/_dropdown-menu.scss +++ b/scss/components/_dropdown-menu.scss @@ -28,11 +28,11 @@ $dropdownmenu-min-width: 200px !default; /// Background color for top level items. /// @type Color -$dropdownmenu-background: $white !default; +$dropdownmenu-background: null !default; /// Background color for dropdowns. /// @type Color -$dropdownmenu-submenu-background: $dropdownmenu-background !default; +$dropdownmenu-submenu-background: $white !default; /// Padding for top level items. /// @type Number @@ -148,12 +148,16 @@ $dropdown-menu-item-background-active: transparent !default; a { @include disable-mouse-outline; + } + + // Top-level item + > li > a { background: $dropdownmenu-background; padding: $dropdownmenu-padding; } - // Active state - .is-active > a { + // Top-level item active state + > li.is-active > a { background: $dropdown-menu-item-background-active; color: $dropdown-menu-item-color-active; }