From 803d04eea0308e7c84556deac4b684f90de7282a Mon Sep 17 00:00:00 2001 From: Daniel Ruf Date: Sat, 16 Jun 2018 09:15:56 +0200 Subject: [PATCH] Use pull request #10936 from DanielRuf/patch/abide-stack-revert-end for v6.5.0 1840a1174 Revert "fix: fix side-effect of jQuery .filter() in Abide.addA11yAttributes", fixes #10935 Signed-off-by: Nicolas Coden --- js/foundation.abide.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/js/foundation.abide.js b/js/foundation.abide.js index b307f29a52..5a72819062 100644 --- a/js/foundation.abide.js +++ b/js/foundation.abide.js @@ -213,8 +213,8 @@ class Abide extends Plugin { */ addA11yAttributes($el) { let $errors = this.findFormError($el); - let $labels = $errors.filter('label').end(); - let $error = $errors.first().end(); + let $labels = $errors.filter('label'); + let $error = $errors.first(); if (!$errors.length) return; // Set [aria-describedby] on the input toward the first form error if it is not set @@ -229,7 +229,7 @@ class Abide extends Plugin { $el.attr('aria-describedby', errorId); } - if ($labels.filter('[for]').end().length < $labels.length) { + if ($labels.filter('[for]').length < $labels.length) { // Get the input ID or create one let elemId = $el.attr('id'); if (typeof elemId === 'undefined') { @@ -242,7 +242,7 @@ class Abide extends Plugin { const $label = $(label); if (typeof $label.attr('for') === 'undefined') $label.attr('for', elemId); - }).end(); + }); } // For each error targeting $el, set [role=alert] if it is not set.