Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-install script breaks on aarch64 platform #159

Closed
Tracked by #391
maxhr opened this issue Aug 2, 2022 · 6 comments
Closed
Tracked by #391

post-install script breaks on aarch64 platform #159

maxhr opened this issue Aug 2, 2022 · 6 comments
Assignees
Labels
bug Something isn't working v2.0

Comments

@maxhr
Copy link
Contributor

maxhr commented Aug 2, 2022

From my (limited) understanding or archs, aarch64 and arm64 are the same.

This checks doesn't allow installation to pass on aarch64:
https://github.com/near/near-sdk-js/blob/develop/cli/post-install.js#L11

For me it breaks inside a Docker container on my mac, and it doesn't break outside the container.

@volovyks
Copy link
Collaborator

volovyks commented Aug 3, 2022

I see it is the same. I would map it to arm64 here: https://github.com/near/near-sdk-js/blob/develop/cli/post-install.js#L4

@volovyks volovyks linked a pull request Aug 3, 2022 that will close this issue
@volovyks
Copy link
Collaborator

volovyks commented Aug 3, 2022

@maxhr please, check if it works if you use code from the attached PR.

@maxhr
Copy link
Contributor Author

maxhr commented Aug 3, 2022

@volovyk-s it fails on:
wget https://github.com/near/binaryen/releases/download/v0.1.10/binaryen-Linux-arm64.tar.gz
says HTTP 404

Inside a Docker container from node:alpine image i have:

uname -s -> Linux
uname -m -> aarch64
uname -a -> Linux ed3742d9a6a2 5.10.104-linuxkit #1 SMP PREEMPT Thu Mar 17 17:05:54 UTC 2022 aarch64 Linux

@volovyks
Copy link
Collaborator

volovyks commented Aug 3, 2022

We do not have a build for ARM Linux, what machine are you using, M1 Mac?
I do not have such hardware, we need to add one more release here: https://github.com/near/binaryen/releases/tag/v0.1.10

@volovyks
Copy link
Collaborator

volovyks commented Aug 3, 2022

@volovyks volovyks mentioned this issue Aug 9, 2022
@ailisp ailisp added the bug Something isn't working label Aug 11, 2022
@exalate-issue-sync exalate-issue-sync bot added v1.0+ bug Something isn't working and removed bug Something isn't working labels Sep 23, 2022
@ailisp ailisp added v2.0 and removed v1.0+ labels Apr 19, 2024
@ailisp ailisp self-assigned this Apr 24, 2024
@ailisp
Copy link
Member

ailisp commented May 2, 2024

done in #393

@ailisp ailisp closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.0
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants
@maxhr @volovyks @ailisp and others