Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS SDK v0.6.0 adds ts-morph devDependency #284

Closed
idea404 opened this issue Nov 4, 2022 · 2 comments · Fixed by #292
Closed

JS SDK v0.6.0 adds ts-morph devDependency #284

idea404 opened this issue Nov 4, 2022 · 2 comments · Fixed by #292
Labels
bug Something isn't working

Comments

@idea404
Copy link
Contributor

idea404 commented Nov 4, 2022 •
edited
Loading

Upgrading repo from v0.5 to v0.6 threw the following error:

image

This was addressed by adding ts-morph to the project devDependencies. Is this intended behavior? Is it not a little forced to require developers to add another dependency they do not expect when using this library?
@idea404 idea404 added the bug Something isn't working label Nov 4, 2022
@ailisp
Copy link
Member

ailisp commented Nov 8, 2022

Good finding! I think ts-morph should be a dependency of near-sdk-js instead of a dev dependency of near-sdk-js. Let's fix it!

@volovyks
Copy link
Collaborator

volovyks commented Nov 8, 2022

@idea404 since you already fixed it, can you please crate the PR?

@idea404 idea404 mentioned this issue Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ts-morph to deps near/near-sdk-js
3 participants
@volovyks @idea404 @ailisp