Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate qimalloc as a replacement for wee_alloc #457

Open
MaksymZavershynskyi opened this issue Jun 19, 2019 · 4 comments
Open

Investigate qimalloc as a replacement for wee_alloc #457

MaksymZavershynskyi opened this issue Jun 19, 2019 · 4 comments

Comments

@MaksymZavershynskyi
Copy link
Contributor

MaksymZavershynskyi commented Jun 19, 2019

Currently we are using wee_alloc for Rust contracts and contracts used in benchmarking. https://github.com/wasmx/qimalloc is used by EWASM and might be potentially faster than the default wee_alloc, since qimalloc optimizes for speed and wee_alloc optimizes for code size. qimalloc however gives only 2-3kb overhead compared to wee_alloc, and in our case using qimalloc might increase the TPS which is more important.

@stale
Copy link

stale bot commented Jul 1, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@bowenwang1996 bowenwang1996 transferred this issue from near/nearcore Jul 2, 2021
@bowenwang1996
Copy link
Contributor

@mikedotexe please check whether this is still relevant

@nagisa
Copy link

nagisa commented Apr 28, 2023

https://crates.io/crates/rlsf is an option to consider. Since WASM code is always single-threaded, concerns about this allocator requiring locks for concurrent use are irrelevant.

@robdefeo
Copy link

From my dependancy bot alert, it is still relevant to replace wee_alloc

Two of the maintainers have indicated that the crate may not be maintained.

The crate has open issues including memory leaks and may not be suitable for production use.

It may be best to switch to the default Rust standard allocator on wasm32 targets.

Last release seems to have been three years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants