Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update env::block_index to env::block_height #460

Closed
austinabell opened this issue Jul 7, 2021 · 1 comment · Fixed by #474
Closed

Update env::block_index to env::block_height #460

austinabell opened this issue Jul 7, 2021 · 1 comment · Fixed by #474
Assignees
@austinabell
Labels
good first issue Good for newcomers

Comments

@austinabell
Copy link
Contributor

austinabell commented Jul 7, 2021 •
edited
Loading

This issue is just to create a new function block_height within the env module and deprecate block_index function as of version 4.0.

The sys interface cannot be changed and it doesn't make sense to migrate the function on the BlockchainInterface trait because it will be removed soon.

Ref: near/nearcore#1903 (comment)

Edit: also potentially worth creating a sys::block_height function, which is not part of the extern "C" interface, but that calls block_index to match the high-level (env) interface.
@austinabell austinabell added the good first issue Good for newcomers label Jul 7, 2021
@austinabell austinabell self-assigned this Jul 15, 2021
@austinabell austinabell mentioned this issue Jul 15, 2021
Merged
@austinabell
Copy link
Contributor Author

Ideally, this comes in the next release so I went ahead and did it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@austinabell austinabell

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: deprecate block_index and replace with block_height near/near-sdk-rs
1 participant
@austinabell