Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ECMAScript decorators (coming in TypeScript 4.8) #9558

Closed
1 task done
smithki opened this issue May 12, 2022 · 1 comment
Closed
1 task done

Support ECMAScript decorators (coming in TypeScript 4.8) #9558

smithki opened this issue May 12, 2022 · 1 comment
Labels
needs triage This issue has not been looked into type: enhancement 🐺

Comments

@smithki
Copy link

smithki commented May 12, 2022

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

The TC39 decorators proposal is stage 3 and TypeScript has plans to implement the spec in version 4.8. I'm new to NestJS, but I figure that supporting the new spec is a large, breaking change for the framework. I don't expect to see a full transition for some time, but it would be nice to track progress in an issue here on GitHub. I'm interested to see the ecosystem move towards standardized decorators sooner rather than later to (hopefully) avoid a similar mess to the one we saw with the transition from CommonJS to ES modules.

Describe the solution you'd like

Find a way to support standardized ECMAScript decorators.

Teachability, documentation, adoption, migration strategy

I'm not experienced enough with NestJS yet to offer advice on adoption strategy.

What is the motivation / use case for changing the behavior?

To future-proof the framework and align to the language standard.

@smithki smithki added needs triage This issue has not been looked into type: enhancement 🐺 labels May 12, 2022
@kamilmysliwiec
Copy link
Member

When it becomes a "thing", we'll start tracking the migration and estimating how much effort & time it will take. Currently, there are too many unknowns, we don't know what the final implementation in TS will work/look like. I hope they won't introduce too many breaking changes as it will undoubtedly greatly hurt the ecosystem.

@nestjs nestjs locked and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs triage This issue has not been looked into type: enhancement 🐺
Projects
None yet
Development

No branches or pull requests

2 participants