Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set REMOTE_AUTH_AUTO_CREATE_USER default to False #1043

Conversation

NeodymiumFerBore
Copy link
Contributor

@NeodymiumFerBore NeodymiumFerBore commented Aug 4, 2023

New Behavior

REMOTE_AUTH_AUTO_CREATE_USER is False when undefined.

Contrast to Current Behavior

REMOTE_AUTH_AUTO_CREATE_USER was True when undefined.

Discussion: Benefits and Drawbacks

REMOTE_AUTH_AUTO_CREATE_USER in netbox-docker release and develop branches is defaulting to True. The netbox documentation says it defaults to False.

netbox-community/netbox/netbox/netbox/settings.py is indeed defaulting to False.

It is defined to True in their configuration_example.py, so maybe it brought confusion at some point.

Benefits

REMOTE_AUTH_AUTO_CREATE_USER default value honors the defined default in the upstream documentation and settings

Drawbacks

Users not defining this value until now may have a surprise on next update.

Changes to the Wiki

None

Proposed Release Note Entry

Set REMOTE_AUTH_AUTO_CREATE_USER default to False

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge merged commit f703bba into netbox-community:develop Aug 16, 2023
5 of 9 checks passed
@tobiasge tobiasge mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants