Set REMOTE_AUTH_AUTO_CREATE_USER default to False #1043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
REMOTE_AUTH_AUTO_CREATE_USER
isFalse
when undefined.Contrast to Current Behavior
REMOTE_AUTH_AUTO_CREATE_USER
wasTrue
when undefined.Discussion: Benefits and Drawbacks
REMOTE_AUTH_AUTO_CREATE_USER
in netbox-docker release and develop branches is defaulting toTrue
. The netbox documentation says it defaults toFalse
.netbox-community/netbox/netbox/netbox/settings.py
is indeed defaulting toFalse
.It is defined to
True
in theirconfiguration_example.py
, so maybe it brought confusion at some point.Benefits
REMOTE_AUTH_AUTO_CREATE_USER
default value honors the defined default in the upstream documentation and settingsDrawbacks
Users not defining this value until now may have a surprise on next update.
Changes to the Wiki
None
Proposed Release Note Entry
Set REMOTE_AUTH_AUTO_CREATE_USER default to False
Double Check
develop
branch.