Add env var for CENSUS_REPORTING_ENABLED #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #999
New Behavior
The configuration.py now additionally checks if the env var CENSUS_REPORTING_ENABLED is set and update the netbox settings accordingly.
Contrast to Current Behavior
Before, wanting to change this behaviour required mounting an additional configuration file into the container.
Discussion: Benefits and Drawbacks
This is a simple quality-of-deployment PR to make deployments easier that wish to opt out of the consensus data reporting.
This PR is backwards-compatible, as the configuration option is only set if the environment variable is present, which should not be the case for current deployments.
When looking over the changes and you have additional suggestions, please feel free to point them out, for example if you wanted this environment variable to be added to netbox.env
Changes to the Wiki
None
Proposed Release Note Entry
Allow configuration of CENSUS_REPORTING_ENABLED via env vars.
Double Check
developbranch.