Unit and Ubuntu update #1167
Merged
Unit and Ubuntu update #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasge
force-pushed
the
unit-ubuntu-update
branch
2 times, most recently
from
3a29a7d
to
060a999
Compare
tobiasge
force-pushed
the
unit-ubuntu-update
branch
from
060a999
to
24eaba7
Compare
cimnine
approved these changes
Mar 26, 2024
| run: ${{ matrix.build_cmd }} | ||
| env: | ||
| BUILDX_PLATFORM: ${{ matrix.platform }} | ||
| BUILDX_BUILDER_NAME: ${{ steps.buildx-setup.outputs.name }} | ||
| - id: arm-time-limit | ||
| name: Set Netbox container start_period higher on ARM64 |
There was a problem hiding this comment.
Name and Id no longer match
There was a problem hiding this comment.
I think this step isn't strictly necessary anymore, because the test are much faster on native ARM64 hardware.
We should revisit this when the Github ARM64 runners are publicly release. Then I will remove the selfhosted runner.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: -
New Behavior
Contrast to Current Behavior
Discussion: Benefits and Drawbacks
Changes to the Wiki
Proposed Release Note Entry
Double Check
developbranch.