Adds HSTS related parameters #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
New Behavior
HSTS and
SECURE_SSL_REDIRECTcan be configured via env variables. Both features are disabled by default.See netbox-community/netbox#15644.
Contrast to Current Behavior
A custom configuration is necessary to configure these. Or a custom reverse proxy configuration.
Discussion: Benefits and Drawbacks
Makes it easier for users to use these security features.
Changes to the Wiki
n/a
Proposed Release Note Entry
Support the following env variables from NetBox. See the NetBox's Security documentation for details.
SECURE_HSTS_INCLUDE_SUBDOMAINSSECURE_HSTS_PRELOADSECURE_HSTS_SECONDSSECURE_SSL_REDIRECTDouble Check
developbranch.