Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Netbox 2.9 #326

Merged
merged 3 commits into from
Sep 1, 2020
Merged

Fixes for Netbox 2.9 #326

merged 3 commits into from
Sep 1, 2020

Conversation

tobiasge
Copy link
Member

Related Issue: #325

New Behavior

  • Startup scripts are compatible with changes made to Netbox 2.9

Contrast to Current Behavior

  • Startup scripts are failing

Discussion: Benefits and Drawbacks

Changes to the Wiki

Proposed Release Note Entry

  • Compatibility with Netbox 2.9

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge requested a review from cimnine August 24, 2020 12:40
@FragmentedPacket
Copy link

Is there anyway to get this merged in soon? I use this repo for development and testing on the Ansible modules and haven't been able to use the released 2.9 versions.

@clearly-tyler-whitney
Copy link

I have sent @cimnine an email regarding this PR, and suggested that they consider write permissions for other contributors.

@kkthxbye-code
Copy link

@jkuzma07 please let me know if you get a response. Forking the repo is another option.

cimnine
cimnine approved these changes Sep 1, 2020
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tobiasge for the adjustments.

@tobiasge tobiasge merged commit e2711ca into netbox-community:develop Sep 1, 2020
@tobiasge tobiasge deleted the fix-startup-2.9 branch September 1, 2020 08:37
@tobiasge tobiasge mentioned this pull request Sep 1, 2020
Merged
@cimnine cimnine added the maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafz olafz olafz approved these changes

@cimnine cimnine cimnine approved these changes

@Tavoons Tavoons Tavoons approved these changes

Assignees
No one assigned
Labels
maintenance The issue describes a maintenance task, such as upgrading a dependency to a certain version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tobiasge @FragmentedPacket @clearly-tyler-whitney @kkthxbye-code @olafz @cimnine @Tavoons