Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added our Python venv to the PATH variable #778

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Added our Python venv to the PATH variable #778

merged 1 commit into from
Jul 14, 2022

Conversation

tobiasge
Copy link
Member

Related Issue: #777

New Behavior

  • Our Python venv is the first path searched for binaries

Contrast to Current Behavior

  • Default python without the needed modules would start

Discussion: Benefits and Drawbacks

  • Users don't need to specify the full path when starting scripts inside the container

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Added Python venv to PATH variable

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge requested a review from cimnine June 22, 2022 10:31
@tobiasge
Added our Python venv to the PATH variable
901ac05 
Now users can run "manage.py" without specifying the full path.
@tobiasge tobiasge merged commit 13d66f2 into netbox-community:develop Jul 14, 2022
@tobiasge tobiasge deleted the path-update branch July 14, 2022 20:37
This was referenced Jul 22, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasge @cimnine