Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0.0 #796

Merged
merged 52 commits into from
Jul 12, 2022
Merged

Version 2.0.0 #796

merged 52 commits into from
Jul 12, 2022

Conversation

tobiasge
Copy link
Member

Noteworthy Changes

This is a major release because the base image is now Debian 11. All users building their own images based on this one must check if they're using Alpine specific commands (like apk). These have to be changed to the Debian version (apt as example).

Fix setting custom field data if custom field object is missing #730

Fixed custom fields problem in initalizers.

feat: Make startup scripts idempotent #729

Running the startup scripts multiple times after changing values won't crash anymore

Added environment variable for CSRF_TRUSTED_ORIGINS #738

CSRF_TRUSTED_ORIGINS can now be set from ENV.

Add support for DeviceType components #742

Added initializers for DeviceType components

Contact startups #728

Added initializers for Contacs and related objects.

Add MAPS_URL to config #750

MAPS_URL can now be set from ENV.

Startup script for cables #736

Added initializers for cables.

Proposing SKIP_GIT now skips all git operations #768

SKIP_GIT now skips all git calls

Update dependency napalm to v4 #791

New major release of Napalm containing a fix that prevented our image from being build.

Compatibility

This version of Netbox Docker is only compatible with Netbox v3.2.x and above.
For older versions, use a previous release of Netbox Docker.

kr3ator and others added 30 commits April 6, 2022 14:09
Fix setting custom field data if custom field object is missing
Co-authored-by: Christian Mäder <cimnine@users.noreply.github.com>
Added environment variable for CSRF_TRUSTED_ORIGINS
Add support for bridge, lag, parent in DCIM Interfaces startup script
…ction-2.x

Update docker/login-action action to v2
@tobiasge tobiasge requested a review from cimnine July 12, 2022 14:52
configuration/extra.py Outdated Show resolved Hide resolved
@cimnine cimnine added the enhancement The issue describes an enhancement that we would like to implement in the future. label Jul 12, 2022
@cimnine
Copy link
Collaborator

cimnine commented Jul 12, 2022

push / Builds new NetBox Docker Images (./build.sh feature) (push) does not see to build, did you see that?

@tobiasge
Copy link
Member Author

push / Builds new NetBox Docker Images (./build.sh feature) (push) does not see to build, did you see that?

That's because the Cable model got changed and the initializers don't work at the moment. But if we fix it for feature it won't work for the current Netbox release anymore.

@ryanmerolle
Copy link
Contributor

We need to think out a updated build process to allow feature branch to be built for user testing, BUT still alert on startup_script issues related to model changes so we can tackle that before a major release.

Its not blocking this PR.

We could introduce:

  • A build for feature without startup_scripts or testing of startup_scripts and call it feautre-untested and keep the feature tag for identifying these issues.
  • A branch for every major release included a feature release where we can build from

CSRF_TRUSTED_ORIGINS is already in configuration.py
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tobias, and thanks to all the amazing contributors.

@cimnine
Copy link
Collaborator

cimnine commented Jul 12, 2022

@ryanmerolle I understand you know a bit about the plugin system of Netbox, don't you? Would it be possible to deliver the startup scripts as a plugin? Then we could split the Docker part from the startup scripts and each could evolve (more) independently.

@tobiasge tobiasge merged commit b45934c into release Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue describes an enhancement that we would like to implement in the future.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants