Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved README.md #825

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Improved README.md #825

merged 1 commit into from
Aug 9, 2022

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented Aug 9, 2022

Related Issue: -

New Behavior

  • Better documentation

Contrast to Current Behavior

  • None

Discussion: Benefits and Drawbacks

  • None

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Updated README.md

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge requested a review from cimnine August 9, 2022 06:33
cimnine
cimnine approved these changes Aug 9, 2022
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to update the hub.docker.com and quay.io Readme's as well?

@tobiasge
Copy link
Member Author

tobiasge commented Aug 9, 2022

Do you plan to update the hub.docker.com and quay.io Readme's as well?

Yes, I will update those as well.

@tobiasge
Improved README.md
8707cef 
- Removed the hint to the `-ldap` tags that where discontinnued with version 2.0.
- Increased minimum Docker version to reflect the needed version for running newer Ubuntu versions. See: https://medium.com/nttlabs/ubuntu-21-10-and-fedora-35-do-not-work-on-docker-20-10-9-1cd439d9921
- Fixed some Markdown linter errors
@tobiasge tobiasge merged commit ada2bd6 into netbox-community:develop Aug 9, 2022
@tobiasge tobiasge deleted the readme-update branch August 19, 2022 08:18
@tobiasge tobiasge mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasge @cimnine