Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that '*' or 'localhost' is always in ALLOWED_HOSTS #912

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Ensure that '*' or 'localhost' is always in ALLOWED_HOSTS #912

merged 2 commits into from
Jan 3, 2023

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented Jan 3, 2023

Related Issue: #907

New Behavior

  • When ALLOWED_HOSTS ist set, ensure that localhost is in the list

Contrast to Current Behavior

  • Health checks could fail when localhost was missing from ALLOWED_HOSTS

Discussion: Benefits and Drawbacks

  • None

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Improved behaviour of the health checks

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge requested a review from cimnine January 3, 2023 13:49
cimnine
cimnine approved these changes Jan 3, 2023
View reviewed changes
configuration/configuration.py Outdated Show resolved Hide resolved
@tobiasge tobiasge merged commit 1403f52 into netbox-community:develop Jan 3, 2023
@tobiasge tobiasge deleted the localhost_allowed_host branch January 3, 2023 18:06
@tobiasge tobiasge mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasge @cimnine