Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced curl with Skopeo for in image functions #956

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Replaced curl with Skopeo for in image functions #956

merged 1 commit into from
Mar 15, 2023

Conversation

tobiasge
Copy link
Member

Related Issue: #954

New Behavior

  • Using skopeo to retrieve image infogmration

Contrast to Current Behavior

  • Many curl call where used

Discussion: Benefits and Drawbacks

  • skopeo is developed to work with remote images and should be better than our own curl calls
  • It is installed in Github Actions worker VM per default

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Improved build checks with the use of skopeo

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge requested a review from cimnine March 15, 2023 08:18
@tobiasge tobiasge force-pushed the 954-use-skopeo branch 2 times, most recently from cafbea7 to 2c94379 Compare March 15, 2023 08:31
@tobiasge tobiasge enabled auto-merge March 15, 2023 08:50
cimnine
cimnine approved these changes Mar 15, 2023
View reviewed changes
build-latest.sh
###
# Check for the jq library needed for parsing JSON
###
if ! command -v jq; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could check for skopeo here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, jq seems to be required still.

@tobiasge tobiasge merged commit f9abdf2 into netbox-community:develop Mar 15, 2023
This was referenced Mar 15, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasge @cimnine