Honour "allowExternalStatus" in TeamCity, be more generous with all-green, fixing fatal bug, work with Intellij 13 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e they were destroyed again meaning the build was permanently unknown
…to work with teamcity 8
…g hyphenations too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tom,
Hope you are well. You might remember me as Davie's friend from various trips to the Magpie!
We're using Ci-Eye at work but we never get to see it go green because there are always builds running and we have some non-test style builds in the project which can go red so I've made some tweaks to honour the "allowExternalStatus" flag in TeamCity configurations.
There seemed to be a fatal bug which meant that observation agencies were destroyed before ever being updated with the actual build status - this meant the monitor was forever grey. I've fixed this but you probably want to check this behaviour more carefully (probably came about from the plugin changes).
I've been more generous with all-green as well. We always have builds running during the day so we never get to see our all-green image. I've changed it to go all-green if all the currently running builds are green as well.
Also Intellij13 treats resources differently. I updated the iml to reflect this (otherwise the plugin structure won't work and you can't run it locally).
Cheers
OIiy