Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderer): optimize function ProtoName #343

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

lspgn
Copy link
Member

@lspgn lspgn commented Aug 13, 2024

Following #341:
Small optimization: avoids going through the condition first, start with protocol lookup.
Combine the if/else

cc @marioschaefer / @DerInti

@lspgn lspgn added the format New or existing formats (json, protobuf, etc.) label Aug 13, 2024
@marioschaefer
Copy link
Contributor

makes sense

@lspgn lspgn merged commit 0fa20c5 into main Aug 14, 2024
1 check passed
@lspgn lspgn deleted the lspgn/optimize-protoname branch August 14, 2024 01:17
lspgn added a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format New or existing formats (json, protobuf, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants