Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both Java 8 and Java 11 #562

Closed
stevehu opened this issue Apr 25, 2022 · 2 comments
Closed

Support both Java 8 and Java 11 #562

stevehu opened this issue Apr 25, 2022 · 2 comments

Comments

@stevehu
Copy link
Contributor

stevehu commented Apr 25, 2022

We have a PR for upgrading to Java 11 at #403

I am opening this issue to discuss the solutions. I am thinking to move the current codebase to 1.0.x branch and use the master branch for Java 11 in the future with 2.0.x tag for releases. New PRs will go to the master branch for Java 11 implementation and only bug fixes go to Java 8 branch 1.0.x. What do you guys think?

@fdutton
Copy link
Contributor

fdutton commented Apr 20, 2023

I have a few thoughts on this:

  • I like the idea of using Java 11's module support to separate the public API from the implementation. Many of the changes I'm making would be easier if I knew that client's have not subclassed an implementation class.
  • Starting work on 2.0 allows make some improvements to the API and possibly add a SPI.
  • Maintaining two versions would be difficult even if it is just bug fixes. I would not start this effort until all the JSON Schema Test Suite checks pass.

@stevehu
Copy link
Contributor Author

stevehu commented Apr 20, 2023

We can have two branches, 1.0.x for Java 8 and the master branch for 2.0.x tags in Java 11. For Java 8, we don't add new features but only bug fixes so that we can encourage users to move to Java 11 as fast as possible. Let's do that once we have all the tests passed. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants