Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential bug in newAppRun #918

Closed
rittneje opened this issue Jun 5, 2024 · 2 comments
Closed

potential bug in newAppRun #918

rittneje opened this issue Jun 5, 2024 · 2 comments
Assignees
Labels

Comments

@rittneje
Copy link
Contributor

rittneje commented Jun 5, 2024

I came across the following code while trying to diagnose an oddity we are seeing with "expected status codes".

if run.Config.ErrorCollector.IgnoreStatusCodes != nil {
run.mu.Lock()
for _, errorCode := range run.Config.ErrorCollector.ExpectStatusCodes {
run.expectErrorCodesCache[errorCode] = true
}
run.mu.Unlock()
}

Should that instead say run.Config.ErrorCollector.ExpectStatusCodes != nil?

@rittneje rittneje added the bug label Jun 5, 2024
@iamemilio
Copy link
Contributor

iamemilio commented Jun 7, 2024

Seems like a likely bug, we will make a ticket for it.

@iamemilio iamemilio self-assigned this Jun 7, 2024
@mirackara
Copy link
Contributor

Released fix with #924. Closing this out for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants