Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize lib/instrumentation/core/http-outbound.js to only parse the URL once #2210

Open
bizob2828 opened this issue May 22, 2024 · 1 comment

Comments

@bizob2828
Copy link
Member

Description

There's a lot of parsing happening in http-outbound.js around the URL. This was noticed while updating this code in #2169. We should parse the URL once and store it in some context to be referenced later. Aside from the url.parse which should get updated in #2209 any references to urltils.* should be optimized and leverage an already parsed URL.

Acceptance Criteria

Only parse the outgoing URL once to do any necessary operations in the lib/instrumentation/core/http-outbound.js.

@workato-integration
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage Needed: Unprioritized Features
Development

No branches or pull requests

1 participant